-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default logging handler to web.run_app (#3243) #3324
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3324 +/- ##
=========================================
- Coverage 98.01% 98% -0.02%
=========================================
Files 43 43
Lines 8025 8030 +5
Branches 1356 1359 +3
=========================================
+ Hits 7866 7870 +4
Misses 66 66
- Partials 93 94 +1
Continue to review full report at Codecov.
|
b11d4e5
to
a746006
Compare
@0az could you please come up with some sort of a regression test? |
Not sure what's going on with codecov. In any case, now that there's a set of tests, I think this can be merged. |
@0az thanks! |
Fixes #3243.
What do these changes do?
Add a default logging handler to
web.run_app
.Are there changes in behavior for the user?
If the
Application.debug
flag is set and the default loggeraiohttp.access
is used, access logs will now be output using astderr
StreamHandler
if no handlers are attached. Furthermore, if the default logger has no log level set, the log level will be set toDEBUG
.Related issue number
This issue fixes #3243.
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.