Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ping / pong default message #3308

Merged
merged 3 commits into from
Oct 1, 2018
Merged

Fix ping / pong default message #3308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
900c296
Fix server ping and pong frames default message
abcdmitry Oct 1, 2018
1334c69
Update changelog
abcdmitry Oct 1, 2018
863ebbe
Add PR number to bugfix
abcdmitry Oct 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/3308.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix default message for server ping and pong frames.
1 change: 1 addition & 0 deletions CONTRIBUTORS.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ Denis Matiychuk
Dima Veselov
Dimitar Dimitrov
Dmitry Doroshev
Dmitry Lukashin
Dmitry Shamov
Dmitry Trofimov
Dmytro Kuznetsov
Expand Down
4 changes: 2 additions & 2 deletions aiohttp/web_ws.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,12 +237,12 @@ def compress(self):
def exception(self):
return self._exception

async def ping(self, message='b'):
async def ping(self, message=b''):
if self._writer is None:
raise RuntimeError('Call .prepare() first')
await self._writer.ping(message)

async def pong(self, message='b'):
async def pong(self, message=b''):
# unsolicited pong
if self._writer is None:
raise RuntimeError('Call .prepare() first')
Expand Down