Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing for web_exceptions #3284

Merged
merged 5 commits into from
Sep 24, 2018
Merged

Add typing for web_exceptions #3284

merged 5 commits into from
Sep 24, 2018

Conversation

kornicameister
Copy link
Contributor

@kornicameister kornicameister commented Sep 23, 2018

What do these changes do?

Adds typings for the web_exceptions as the next step for #1749

Are there changes in behavior for the user?

None, just typings

Related issue number

partially #1749

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov-io
Copy link

codecov-io commented Sep 23, 2018

Codecov Report

Merging #3284 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3284      +/-   ##
==========================================
- Coverage   98.03%   97.99%   -0.04%     
==========================================
  Files          43       43              
  Lines        7894     7896       +2     
  Branches     1354     1354              
==========================================
- Hits         7739     7738       -1     
- Misses         63       65       +2     
- Partials       92       93       +1
Impacted Files Coverage Δ
aiohttp/web_exceptions.py 100% <100%> (ø) ⬆️
aiohttp/tcp_helpers.py 90% <0%> (-6.67%) ⬇️
aiohttp/client_reqrep.py 97.47% <0%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb85a7...87ca063. Read the comment docs.

@asvetlov asvetlov merged commit 044996a into aio-libs:master Sep 24, 2018
@asvetlov
Copy link
Member

thanks!

@kornicameister kornicameister deleted the typing_web_exceptions branch September 24, 2018 20:39
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
If you feel like there's important points made in this discussion, please include those excerpts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants