-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn vendored Node.js' http-parser into a git submodule #3011
Turn vendored Node.js' http-parser into a git submodule #3011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation should be updated to reflect the fact that bare git clone
doesn't work anymore.
|
Codecov Report
@@ Coverage Diff @@
## master #3011 +/- ##
=======================================
Coverage 98.09% 98.09%
=======================================
Files 42 42
Lines 7707 7707
Branches 1344 1344
=======================================
Hits 7560 7560
Misses 51 51
Partials 96 96 Continue to review full report at Codecov.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
What do these changes do?
Replace a copy-pasted http-parser contents with git-trackable submodule. I recall @asvetlov was encouraging to do this PR a while back.
Side-effect: also update vendored lib to currently latest version.
Are there changes in behavior for the user?
Only for devs, they might want to use
--recurse-submodules
when doinggit clone
Related issue number
‒
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.