-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in FileResponse when compression wouldn't work #2944
Fix bug in FileResponse when compression wouldn't work #2944
Conversation
@@ -43,7 +43,7 @@ def __init__(self, *, status=200, reason=None, headers=None): | |||
self._keep_alive = None | |||
self._chunked = False | |||
self._compression = False | |||
self._compression_force = False | |||
self._compression_force = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this so that type is simplified to Optional[ContentCoding]
, not Union[None, bool, ContentCoding]
Codecov Report
@@ Coverage Diff @@
## master #2944 +/- ##
=======================================
Coverage 97.99% 97.99%
=======================================
Files 40 40
Lines 7514 7514
Branches 1318 1318
=======================================
Hits 7363 7363
Misses 48 48
Partials 103 103
Continue to review full report at Codecov.
|
Thank you! |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
Closes #2942
What do these changes do?
Compression of FileResponse's now works
Are there changes in behavior for the user?
Compression works
Related issue number
#2942
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.