Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose app property for TestClient #2901

Merged
merged 9 commits into from
Apr 2, 2018
Merged

Conversation

thomaszdxsn
Copy link
Contributor

What do these changes do?

expose app property for TestClient

Are there changes in behavior for the user?

former usage must access test_client.server.app, now is easy, justtest_client.app

Related issue number

#2891

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • Add a new news fragment into the CHANGES folder

@thomaszdxsn
Copy link
Contributor Author

thomaszdxsn commented Apr 2, 2018

I don't know why file's changed contain docs/client_reference.rst, no diff obviously

@codecov-io
Copy link

codecov-io commented Apr 2, 2018

Codecov Report

Merging #2901 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2901      +/-   ##
==========================================
+ Coverage   97.98%   97.98%   +<.01%     
==========================================
  Files          40       40              
  Lines        7504     7506       +2     
  Branches     1316     1316              
==========================================
+ Hits         7353     7355       +2     
  Misses         48       48              
  Partials      103      103
Impacted Files Coverage Δ
aiohttp/test_utils.py 98.85% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52dd00c...991b24c. Read the comment docs.

@asvetlov asvetlov merged commit 4e22d40 into aio-libs:master Apr 2, 2018
@asvetlov
Copy link
Member

asvetlov commented Apr 2, 2018

Thanks!

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants