Document encoding detection behavior for unknown encodings. #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, cchardet might detect encodings that Python doesn't know. In such cases, `.text()` function might raise a `LookupError`, and `get_encoding` may return values that are unsafe to pass to `bytes.decode()` or to `.text()` functions. Closes aio-libs#2732
Codecov Report
@@ Coverage Diff @@
## master #2733 +/- ##
==========================================
+ Coverage 97.85% 97.99% +0.13%
==========================================
Files 39 39
Lines 7335 7335
Branches 1283 1283
==========================================
+ Hits 7178 7188 +10
+ Misses 50 45 -5
+ Partials 107 102 -5
Continue to review full report at Codecov.
|
asvetlov
approved these changes
Feb 13, 2018
|
Thanks! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
psf-chronographer
bot
added
the
bot:chronographer:provided
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2732
What do these changes do?
Document that sometimes, cchardet might detect encodings that Python doesn't know. In such cases,
.text()function might raise aLookupError, andget_encodingmay return values that are unsafe to pass tobytes.decode()or to.text()functions.Are there changes in behavior for the user?
No.
Related issue number
#2732
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.