Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check install idna-ssl or not on Python3.7 #2703

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

hellysmile
Copy link
Member

What do these changes do?

idna_ssl is not installed on Python3.7 as dependency

otherwise on Python3.7 will be

idna-ssl requires Python '<3.7.0' but the running Python is 3.7.0

@codecov-io
Copy link

codecov-io commented Feb 2, 2018

Codecov Report

Merging #2703 into 2.3 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.3    #2703   +/-   ##
=======================================
  Coverage   97.58%   97.58%           
=======================================
  Files          35       35           
  Lines        7439     7439           
  Branches     1295     1295           
=======================================
  Hits         7259     7259           
  Misses         71       71           
  Partials      109      109

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21ab511...2e4801a. Read the comment docs.

@asvetlov asvetlov merged commit 3dfad7a into aio-libs:2.3 Feb 2, 2018
@hellysmile hellysmile deleted the no_idna_ssl_on_python37 branch February 2, 2018 10:50
'async_timeout>=1.2.0', 'yarl>=1.0.0']


if sys.version_info < (3, 7):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same could be done with extras+markers. Smth like:

extra_requires = {
    ':python_version<"3.7"': ['idna-ssl>=1.0.0']
}

@asvetlov
Copy link
Member

asvetlov commented Feb 3, 2018

Yep, maybe your proposal is more elegant -- but I don't care too much

@webknjaz
Copy link
Member

webknjaz commented Feb 4, 2018

it's just a note for future if I ever get to doing #2397

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants