-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added check install idna-ssl or not on Python3.7 #2703
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.3 #2703 +/- ##
=======================================
Coverage 97.58% 97.58%
=======================================
Files 35 35
Lines 7439 7439
Branches 1295 1295
=======================================
Hits 7259 7259
Misses 71 71
Partials 109 109 Continue to review full report at Codecov.
|
'async_timeout>=1.2.0', 'yarl>=1.0.0'] | ||
|
||
|
||
if sys.version_info < (3, 7): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same could be done with extras+markers. Smth like:
extra_requires = {
':python_version<"3.7"': ['idna-ssl>=1.0.0']
}
Yep, maybe your proposal is more elegant -- but I don't care too much |
it's just a note for future if I ever get to doing #2397 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
What do these changes do?
idna_ssl is not installed on Python3.7 as dependency
otherwise on Python3.7 will be
idna-ssl requires Python '<3.7.0' but the running Python is 3.7.0