Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop await aiohttp.request() syntax for sake of context manager #2541

Merged
merged 11 commits into from
Nov 21, 2017

Conversation

asvetlov
Copy link
Member

Fixes #2540

@codecov-io
Copy link

codecov-io commented Nov 20, 2017

Codecov Report

Merging #2541 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2541      +/-   ##
==========================================
+ Coverage   97.16%   97.26%   +0.09%     
==========================================
  Files          40       40              
  Lines        8193     8147      -46     
  Branches     1441     1440       -1     
==========================================
- Hits         7961     7924      -37     
+ Misses        100       92       -8     
+ Partials      132      131       -1
Impacted Files Coverage Δ
aiohttp/helpers.py 97.77% <ø> (-0.02%) ⬇️
aiohttp/test_utils.py 98.21% <100%> (ø) ⬆️
aiohttp/web_protocol.py 88.47% <0%> (+0.31%) ⬆️
tests/autobahn/client.py 96.99% <0%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39ea168...e7b08c3. Read the comment docs.

@asvetlov
Copy link
Member Author

PR is done.
Will merge it tomorrow if nobody objects.

@asvetlov asvetlov merged commit 439c732 into master Nov 21, 2017
@asvetlov asvetlov deleted the context-manager branch November 21, 2017 17:16
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop await aiohttp.request(...)
2 participants