Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop await aiohttp.request(...) #2540

Closed
asvetlov opened this issue Nov 20, 2017 · 1 comment · Fixed by #2541 or #2543
Closed

Drop await aiohttp.request(...) #2540

asvetlov opened this issue Nov 20, 2017 · 1 comment · Fixed by #2541 or #2543
Labels
client enhancement outdated
Milestone
3.0

Comments

@asvetlov
Copy link
Member

Closing request/session is too error-prone in the case, especially if an exception was generated.

The only robust solution is prohibiting await request() syntax but supporting async with request() as resp: only.

After implementing proposed restriction we'll get very clean context and behavior.
@asvetlov asvetlov added this to the 3.0 milestone Nov 20, 2017
asvetlov added a commit that referenced this issue Nov 20, 2017
@asvetlov
Fix #2540: Drop await aiohttp.request() syntax for sake of context ma…
dda5766 
…nager
This was referenced Nov 20, 2017
Merged
Merged
asvetlov added a commit that referenced this issue Nov 21, 2017
@asvetlov
Drop await aiohttp.request() syntax for sake of context manager (#2541)
439c732 
* Get rid of more yield froms

* Fix #2540: Drop await aiohttp.request() syntax for sake of context manager

* Fix typo

* Work on dropping Python 3.4 functionality

* Fix typo

* Fix flake8

* Fix spelling

* Code cleanup
@asvetlov asvetlov mentioned this issue Sep 18, 2018
Closed
@aio-libs-bot aio-libs-bot mentioned this issue Dec 6, 2018
Closed
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
client enhancement outdated
Projects
None yet
Milestone
3.0
1 participant
@asvetlov