Fix wrap ssl errors for proxy connector. #2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
asvetlov
approved these changes
Oct 30, 2017
Codecov Report
@@ Coverage Diff @@
## 2.3 #2446 +/- ##
=======================================
Coverage 97.24% 97.24%
=======================================
Files 39 39
Lines 8231 8231
Branches 1442 1442
=======================================
Hits 8004 8004
Misses 98 98
Partials 129 129
Continue to review full report at Codecov.
|
asvetlov
pushed a commit
that referenced
this pull request
Nov 1, 2017
* Fix wrap oserrors. (#2442) * Fix wrap oserrors. * Skip unix socket tests on windows * Fix wrap ssl errors for proxy connector. (#2446) * Fix 2451: Rename from_env to trust_env in client reference. * Fix connection for multiple dns hosts (#2447) * Proof of concept fix for multiple dns hosts * Revert getpeercert * Added test for multiple dns hosts and errors. * Added change notes. * Remove redunant assert. * Minor docs formatting * Move TOC to separate RST file * Build tarball on appveyor * Bump to 2.3.2b1 * @asyncio.coroutine -> async * Update index.rst * Update toc.rst
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
psf-chronographer
bot
added
the
bot:chronographer:provided
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fix wrapping ssl related errors for proxy connector
Are there changes in behavior for the user?
ssl.SSLErrorwrapped toaiohttp.ClientConnectorSSLErrorandssl.CertificateErrorwrapped toaiohttp.ClientConnectorCertificateErrorRelated issue number
#2408
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bug)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.