Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in ClientWebSocketResponse.closed doc #2425

Merged
merged 1 commit into from
Oct 27, 2017

Conversation

samueldg
Copy link
Contributor

What do these changes do?

Fix a small typo in the client reference docs, for ClientWebSocketResponse.closed

"of" -> "on"

Are there changes in behavior for the user?

No.

Related issue number

No tracked issue.

@samueldg
Copy link
Contributor Author

I didn't include a changelog entry, as the CONTRIBUTING file states these are for "non trivial" changes.

Let me know if you want me to add that!

@codecov-io
Copy link

codecov-io commented Oct 27, 2017

Codecov Report

Merging #2425 into 2.3 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.3    #2425   +/-   ##
=======================================
  Coverage   97.23%   97.23%           
=======================================
  Files          39       39           
  Lines        8224     8224           
  Branches     1442     1442           
=======================================
  Hits         7997     7997           
  Misses         98       98           
  Partials      129      129

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b526a6d...3511169. Read the comment docs.

@asvetlov asvetlov merged commit 94a9162 into aio-libs:2.3 Oct 27, 2017
@samueldg samueldg deleted the fix/client-reference-doc-typo branch October 27, 2017 22:05
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants