-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSL Errors are not caught by proxy connector #2408
Comments
@hellysmile please check. @Insoleet what aiohttp version do you use? |
I got this error on a build using aiohttp 2.3.1 |
@Insoleet Hey, this is an issue, I'll do proposal for fix today |
Fixed by #2446 in 2.3 branch, but it is not in master yet. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
Long story short
I'm running an application which can connects to many heterogeneous systems. Sometimes, SSL is badly done and verify fails.
When using a proxy connector, the exception is not catched by aiohttp. So my application, which is only waiting for standard aiohttp exception, fails to catch this one.
Expected behaviour
I expected the connector to catch this error so that it can throw an aiottp exception ClientSSLError, like the standard connector : https://github.com/aio-libs/aiohttp/blob/master/aiohttp/connector.py#L822
Actual behaviour
Steps to reproduce
Connect to a self-signed HTTPS website, throught a proxy.
Your environment
Windows 64 bits, python 3.5.
The text was updated successfully, but these errors were encountered: