Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix templates example in tutorial #2390

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Fix templates example in tutorial #2390

merged 1 commit into from
Oct 24, 2017

Conversation

patrickporto
Copy link
Contributor

What do these changes do?

Added dict app of request in Tutorial.

Are there changes in behavior for the user?

Better documentation

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the changes folder
    • name it <issue_id>.<type> for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@asvetlov asvetlov merged commit bfcf9e9 into aio-libs:master Oct 24, 2017
@asvetlov
Copy link
Member

Nice catch!
Thanks!

dfee pushed a commit to dfee/aiohttp that referenced this pull request Oct 24, 2017
@patrickporto @dfee
Fix tutorial example in Templates subject (aio-libs#2390)
ac1d3fb 
Added aiohttp-graphql

Ref: aio-libs#2288

fixed typo
@webknjaz
Copy link
Member

@asvetlov just a random note:

literalinclude directive supported by SphinX would let us keep example and docs in sync. Also we could extend this to having a separate CI job testing specifically examples/demos and be sure that snippets in docs refer exactly to the source we have in repo, not outdated version of it.

@asvetlov
Copy link
Member

It could be cool (we could run tests for demos too if present).
Unfortunately I pretty sure I'll never find a time for it personally :(
Any contribution is welcome.
@webknjaz please create issues at least.

@webknjaz webknjaz mentioned this pull request Oct 25, 2017
Closed
2 tasks
asvetlov pushed a commit that referenced this pull request Oct 27, 2017
@dfee @asvetlov
Added aiohttp-graphql (#2381)
cff1263 
* Fix tutorial example in Templates subject (#2390)

Added aiohttp-graphql

Ref: #2288

fixed typo

* Update third_party.rst
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrickporto @asvetlov @webknjaz