Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop resolve param from TCPConnector #2379

Merged
merged 1 commit into from
Oct 23, 2017
Merged

drop resolve param from TCPConnector #2379

merged 1 commit into from
Oct 23, 2017

Conversation

jairhenrique
Copy link
Contributor

fix #2377

asvetlov
asvetlov requested changes Oct 23, 2017
View reviewed changes
Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGES/2377.removal changenote is required

@oleksandr-kuzmenko
Copy link
Contributor

@jairhenrique can you please add new record in CHANGES folder?

@asvetlov asvetlov merged commit 249df62 into aio-libs:master Oct 23, 2017
@asvetlov
Copy link
Member

thanks!

@jairhenrique jairhenrique deleted the drop_resolve_param branch October 29, 2017 12:46
@Min3953 Min3953 mentioned this pull request Mar 8, 2018
Merged
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop resovle param from TCPConnector
3 participants
@jairhenrique @oleksandr-kuzmenko @asvetlov