Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix middleware warning #2341

Merged
merged 3 commits into from
Oct 18, 2017
Merged

Fix middleware warning #2341

merged 3 commits into from
Oct 18, 2017

Conversation

asvetlov
Copy link
Member

Fix for #2340

@asvetlov asvetlov changed the base branch from 2.3 to 2.2 October 18, 2017 11:25
@asvetlov asvetlov changed the base branch from 2.2 to 2.3 October 18, 2017 11:25
@samuelcolvin samuelcolvin self-requested a review October 18, 2017 11:28
samuelcolvin
samuelcolvin approved these changes Oct 18, 2017
View reviewed changes
Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kxepal
kxepal approved these changes Oct 18, 2017
View reviewed changes
Copy link
Member

@kxepal kxepal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-io
Copy link

codecov-io commented Oct 18, 2017 •
edited
Loading

Codecov Report

Merging #2341 into 2.3 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.3    #2341   +/-   ##
=======================================
  Coverage   97.23%   97.23%           
=======================================
  Files          39       39           
  Lines        8224     8224           
  Branches     1442     1442           
=======================================
  Hits         7997     7997           
  Misses         98       98           
  Partials      129      129
Impacted Files Coverage Δ
aiohttp/web.py 99.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2884d0...197c861. Read the comment docs.

@asvetlov asvetlov merged commit c35eebd into 2.3 Oct 18, 2017
@asvetlov asvetlov deleted the fix-middleware-warning branch October 18, 2017 13:52
@asvetlov asvetlov mentioned this pull request Oct 18, 2017
Closed
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samuelcolvin samuelcolvin samuelcolvin approved these changes

@kxepal kxepal kxepal approved these changes

Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asvetlov @codecov-io @kxepal @samuelcolvin