Implement Brotli support

[oleksandr-kuzmenko]

What do these changes do?

Implement Brotli support

Are there changes in behavior for the user?

No.

Related issue number

#2270

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• If you provide code modification, please add yourself to CONTRIBUTORS.txt
• Add a new news fragment into the changes folder

[asvetlov]

Good start but tests are required.

[codecov-io]

Codecov Report

Merging #2312 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2312      +/-   ##
==========================================
+ Coverage   97.23%   97.23%   +<.01%     
==========================================
  Files          39       39              
  Lines        8174     8179       +5     
  Branches     1430     1430              
==========================================
+ Hits         7948     7953       +5     
  Misses         98       98              
  Partials      128      128

Impacted Files	Coverage Δ
aiohttp/http_parser.py	97.79% <100%> (+0.02%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfed2f1...4a1ac01. Read the comment docs.

[oleksandr-kuzmenko]

I hope this is not a big problem
Coverage 97.23% 97.18% -0.05%

[asvetlov]

I pretty happy with the value.
Please add # pragma: no cover for lines which are executed if no brotlipy installed.

[hellysmile]

Hello there, recently I was playing with exactly brotli and were using official python package.

Is there any difference between https://pypi.python.org/pypi/Brotli and https://pypi.python.org/pypi/brotlipy

Can we support both of them?

[oleksandr-kuzmenko]

@hellysmile hello
I can't find docs for google brotli py-package =(

Brotlipy is a collection of bindings to the Brotli C library by Google, has docs and:

Brotlipy has a very similar interface to the standard library’s zlib module

I think no:

Can we support both of them?

[oleksandr-kuzmenko]

Coverage 97.23% 97.23% +<.01%
FYI @asvetlov

[asvetlov]

Perfect, thank you
Looks like brotli and brotlipy have the same API

I'd like to have brotli compression support on both client and server sides but it's definitely a subject for other PRs

[oleksandr-kuzmenko]

In the near future I will try to add brotli support to server side

[asvetlov]

I mean now we do support brotli decompression only, compressing requests/responses would be very useful too.

[oleksandr-kuzmenko]

I got what you meant

[kxepal]

awesome!

[hellysmile]

I've tried to play around brotli\brotlipy, at least test is green on both of them.

[asvetlov]

Looks like we need mention both libraries in doc

[oleksandr-kuzmenko]

ok, i'll update docs

[webknjaz]

Why this has no cover? Good coverage matters

[webknjaz]

brotlipy package could be added to extras in setup.py for usability reasons.

[asvetlov]

We don't use extras in aiohttp (but I like the idea).
Hmm, we should mention brotly/brotlipy as optional dependency in index.rst and README.rst along with cchardet and aiodns.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new