Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use trafaret.IP instead #2187

Merged
merged 2 commits into from
Aug 10, 2017
Merged

use trafaret.IP instead #2187

merged 2 commits into from
Aug 10, 2017

Conversation

thijstriemstra
Copy link
Contributor

Trafaret provides an IP type.

@thijstriemstra
Copy link
Contributor Author

And without this change the demo breaks with Trafaret >= 0.11

@asvetlov asvetlov merged commit 4b498d1 into aio-libs:master Aug 10, 2017
@asvetlov
Copy link
Member

Thanks!
I very appreciate PRs for aiohttp demos.
Unfortunately demos are not test covered by their nature. Test suite need Postgres and manual steps for adding pg user, etc. and etc.
Thus the baby lives without parent control and it is outdated very often.

@asvetlov
Copy link
Member

If you want to polish http://aiohttp.readthedocs.io/en/stable/tutorial.html -- you are welcome

@codecov-io
Copy link

Codecov Report

Merging #2187 into master will decrease coverage by 0.46%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2187      +/-   ##
==========================================
- Coverage   97.15%   96.68%   -0.47%     
==========================================
  Files          39       39              
  Lines        7895     7895              
  Branches     1367     1367              
==========================================
- Hits         7670     7633      -37     
- Misses        100      113      +13     
- Partials      125      149      +24
Impacted Files Coverage Δ
aiohttp/helpers.py 93.98% <0%> (-3.35%) ⬇️
tests/autobahn/client.py 94.65% <0%> (-2.21%) ⬇️
aiohttp/streams.py 98% <0%> (-0.75%) ⬇️
aiohttp/test_utils.py 97.92% <0%> (-0.7%) ⬇️
aiohttp/multipart.py 94.9% <0%> (-0.55%) ⬇️
examples/client_ws.py 95.81% <0%> (-0.53%) ⬇️
aiohttp/web_response.py 98.19% <0%> (-0.52%) ⬇️
examples/web_ws.py 94.77% <0%> (-0.41%) ⬇️
aiohttp/client_reqrep.py 96.98% <0%> (-0.22%) ⬇️
aiohttp/connector.py 97.44% <0%> (-0.22%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c04a75a...2e5688a. Read the comment docs.

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants