Fixed issue #2118

[pieterb]

Are there changes in behavior for the user?

The signature of DynamicResource.__init__() changed. This signature is not (yet) part of the public interface, and probably not used by third party developers, as its mostly useless in its old form.

Related issue number

#2118

Checklist

• [*] I think the code is well written
• [*] Unit tests for the changes exist
• [n/a] Documentation reflects the changes
• [*] If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• [*] Add a new news fragment into the changes folder
  • name it <issue_id>.<type> for example (588.bug)
  • if you don't have an issue_id change it to the pr id after creating the pr
  • ensure type is one of the following:
    • .feature: Signifying a new feature.
    • .bugfix: Signifying a bug fix.
    • .doc: Signifying a documentation improvement.
    • .removal: Signifying a deprecation or removal of public API.
    • .misc: A ticket has been closed, but it is not of interest to users.
  • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

[codecov-io]

Codecov Report

Merging #2119 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #2119   +/-   ##
=======================================
  Coverage   97.11%   97.11%           
=======================================
  Files          38       38           
  Lines        7694     7694           
  Branches     1346     1346           
=======================================
  Hits         7472     7472           
  Misses        101      101           
  Partials      121      121

Impacted Files	Coverage Δ
aiohttp/web_urldispatcher.py	99.41% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 240a0e2...cda911d. Read the comment docs.

[asvetlov]

I'm ok for merging after dropping changes record.
But please keep in mind: the API is not a part of Public API, the code might be modified without any backward compatibility

[asvetlov]

Please drop the file: the change is not related to public API, I don't want to attract attention by this record

[pieterb]

Done!

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.