Fix bug in CookieJar when a cookie would be expired by mistake #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roganov
force-pushed
the
fix-cookiejar-#2084
branch
from
412c25e to
bb63a3c
Compare
Codecov Report
@@ Coverage Diff @@
## 2.2 #2088 +/- ##
=======================================
Coverage 97.03% 97.03%
=======================================
Files 38 38
Lines 7684 7684
Branches 1341 1341
=======================================
Hits 7456 7456
Misses 104 104
Partials 124 124
Continue to review full report at Codecov.
|
asvetlov
reviewed
Jul 13, 2017
tests/test_cookiejar.py
Outdated
| jar.update_cookies(SimpleCookie('foo="bar"')) | ||
|
|
||
| # Assert that there a cookie. | ||
| assert jar |
There was a problem hiding this comment.
Please use more obvious check.
assert len(jar) == 1 for example
roganov
force-pushed
the
fix-cookiejar-#2084
branch
from
bb63a3c to
29f4f7d
Compare
roganov
force-pushed
the
fix-cookiejar-#2084
branch
from
29f4f7d to
d2bb2c5
Compare
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fixes #2084
Unfortunately I couldn't come up with a test case other than to record uvloop's timestamps and replay them. Obviously it highly depends on the internals on CookieJar and the test may become irrelevant it code changes.
Are there changes in behavior for the user?
Hopefully not.
Related issue number
#2084
Checklist
CONTRIBUTORS.txtchangesfolder<issue_id>.<type>for example (588.bug)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.