-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added a built with page in the docs #2017
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2017 +/- ##
=======================================
Coverage 97.05% 97.05%
=======================================
Files 38 38
Lines 7699 7699
Branches 1347 1347
=======================================
Hits 7472 7472
Misses 103 103
Partials 124 124 Continue to review full report at Codecov.
|
Thanks |
================== | ||
|
||
aiohttp is used to build useful libraries built on top of it, | ||
and there's a page dedicated to list them: :ref:`aiohttp-3rd-party`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please feel free to propose better sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean wrong link. Wrong visual render and not clickable. Am I wrong ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@socketpair would you fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunatelly I'm not an expert in RST. @jerryramires will try to fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@socketpair @asvetlov it's rendering well on http://aiohttp.readthedocs.io/en/latest/built_with.html
Notice that the "ref" markup is only rendered by Sphinx, not github's restructuredtext renderer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tarekziade thanks for correction.
Now I finally understand why @socketpair raised the issue.
Nothing to do here.
What do these changes do?
Are there changes in behavior for the user?
Related issue number
Checklist
CONTRIBUTORS.txt
changes
folder<issue_id>.<type>
for example (588.bug)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.