Remove Content-Length when you enable chunked encoding

[julien-duponchelle]

This ensure that no content lenght header remain after you enable
chunked.

What do these changes do?

Remove Content-Length when you enable chunked encoding

This ensure that no content lenght header remain after you enable chunked.

Are there changes in behavior for the user?

No Content-Length will be send when you have enable chunked encoding

Related issue number

No issue

Checklist

• [*] I think the code is well written
• [*] Unit tests for the changes exist
• [*] Documentation reflects the changes
• [*] If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• [*] Add a new entry to CHANGES.rst
  • Choose any open position to avoid merge conflicts with other PRs.
  • Add a link to the issue you are fixing (if any) using #issue_number format at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.

[fafhrd91]

This have to be exception. This is mistake to supply content-length and enable chunking.

[hubo1016]

I believe Content-Length header is already removed in _start method.

[julien-duponchelle]

I will make more tests in order to understand why we have content length set to zero even if we didn't set it. Which exception should be raise ? Le mer. 31 mai 2017 à 09:56, Hu Bo <[email protected]> a écrit :

…

I believe Content-Length header is already removed in *_start* method. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1933 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVFXQ6BlgwTWYedPHBnHgG8CkdNqpxjks5r_R0OgaJpZM4NqIEw> .

[asvetlov]

RuntimeError is enough I guess.
@noplay would you create a PR for this fix?

[julien-duponchelle]

I will do it in the coming day. Against 2.0 branch or master? Le mer. 31 mai 2017 à 20:39, Andrew Svetlov <[email protected]> a écrit :

…

RuntimeError is enough I guess. @noplay <https://github.com/noplay> would you create a PR for this fix? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1933 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVFXSw6V8z0Ac0n3bSddHdjsv2Gcv2Nks5r_bPMgaJpZM4NqIEw> .

[fafhrd91]

Against master

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.