Fix #1828: make enable_compression work on HTTP/1.0

[hubo1016]

What do these changes do?

This pr fix #1828 i.e. generate a correctly compressed response for HTTP/1.0 requests.

Are there changes in behavior for the user?

Call enable_compression on Response class with body set to some bytes now generates a response with content-length instead of chunk-encoded response.

Related issue number

#1828

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• Add a new entry to CHANGES.rst
  • Choose any open position to avoid merge conflicts with other PRs.
  • Add a link to the issue you are fixing (if any) using #issue_number format at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.

[codecov-io]

Codecov Report

Merging #1910 into master will increase coverage by <.01%.
The diff coverage is 94.28%.

@@            Coverage Diff             @@
##           master    #1910      +/-   ##
==========================================
+ Coverage   97.05%   97.06%   +<.01%     
==========================================
  Files          38       38              
  Lines        7674     7695      +21     
  Branches     1339     1346       +7     
==========================================
+ Hits         7448     7469      +21     
- Misses        102      103       +1     
+ Partials      124      123       -1

Impacted Files	Coverage Δ
aiohttp/web_response.py	98.71% <94.28%> (+0.07%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44ebcac...a634b57. Read the comment docs.

[asvetlov]

Looks like you've committed an syntax error :)

[hubo1016]

@asvetlov fixed

[asvetlov]

Codecov reports that your change is not fully covered by tests.
Albeit it's sometimes acceptable we want to keep our test coverage level.
Please run make cov-dev and fix missing cases by adding new tests.

[hubo1016]

This branch cannot be covered in current version because all the content_length implementations do not return None when there is a Content-Length header. But I think it is necessary in case there are other implementations in the future. We should not rely on the current implementations.

[hubo1016]

@asvetlov Seems that codecov report is not updating, now it is reported as
aiohttp/web_response.py 383 4 186 3 99%

Among the missing statements and branches, only one statement and one branch is related to this pr. The reason is updated in the above comment.

[hubo1016]

@asvetlov any response?

[asvetlov]

Please create a PR against master.
Also your change fails one test on master branch.

[asvetlov]

The last tiny change: move a record in CHANGES.txt to 2.3 version

[asvetlov]

Ok, I'll update CHANGES in merging.

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.