Write to transport \r\n before closing after keepalive timeout #1883 #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kxepal
requested changes
May 12, 2017
aiohttp/web_protocol.py
Outdated
| @@ -268,6 +268,7 @@ def eof_received(self): | |||
| pass | |||
|
|
|||
| def data_received(self, data): | |||
| print("data:", data) | |||
aiohttp/web_protocol.py
Outdated
| @@ -336,13 +337,15 @@ def close(self): | |||
| if not waiter.done(): | |||
| waiter.cancel() | |||
|
|
|||
| def force_close(self): | |||
| def force_close(self, keepalive=False): | |||
There was a problem hiding this comment.
I think the argment name a bit misleading. send_last_heartbeat - might be more precisely about what will happen. The keepalive fits more to class property which can be enabled or disabled.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.