Fix noop for python 3.4

[emlove]

What do these changes do?

This change switches the noop helper in python 3.4 from returning a tuple to returning an empty coroutine. Python 3.4 supports the coroutine decorator syntax, so I'm not sure why this was done differently to begin with. The current code is causing assertion errors when the coroutine is passed to loop.create_task.

After this change both branches were the same, so the branching is removed.

Are there changes in behavior for the user?

No

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• Add a new entry to CHANGES.rst
  • Choose any open position to avoid merge conflicts with other PRs.
  • Add a link to the issue you are fixing (if any) using #issue_number format at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.

[fafhrd91]

could you rebase against master and fix spelling

[emlove]

Sure. Can you point out the spelling problem, though?

[fafhrd91]

you can do "make doc-spelling"

https://travis-ci.org/aio-libs/aiohttp/jobs/226199011

[codecov-io]

Codecov Report

Merging #1847 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1847   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files          37       37           
  Lines        7509     7509           
  Branches     1306     1306           
=======================================
  Hits         7298     7298           
  Misses         89       89           
  Partials      122      122

Impacted Files	Coverage Δ
aiohttp/helpers.py	96.79% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f51eca...f6908f3. Read the comment docs.

[emlove]

Done. Thanks for pointing me in the right direction.

[fafhrd91]

Thanks

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.