Update StreamResponse.write annotation for strict-bytes #10154

cdce8p · 2024-12-10T21:25:54Z

What do these changes do?

Mypy will add a --strict-bytes flag. python/mypy#18263

With that bytearray and memoryview are no longer subclasses of bytes and must be listed explicitly instead if they are supported.

Are there changes in behavior for the user?

--

Related issue number

--

Checklist

I think the code is well written
Unit tests for the changes exist
Documentation reflects the changes
If you provide code modification, please add yourself to CONTRIBUTORS.txt
- The format is <Name> <Surname>.
- Please keep alphabetical order, the file is sorted by names.
Add a new news fragment into the CHANGES/ folder
- name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)
- if you don't have an issue number, change it to the pull request
  number after creating the PR
  - .bugfix: A bug fix for something the maintainers deemed an
    improper undesired behavior that got corrected to match
    pre-agreed expectations.
  - .feature: A new behavior, public APIs. That sort of stuff.
  - .deprecation: A declaration of future API removals and breaking
    changes in behavior.
  - .breaking: When something public is removed in a breaking way.
    Could be deprecated in an earlier release.
  - .doc: Notable updates to the documentation structure or build
    process.
  - .packaging: Notes for downstreams about unobvious side effects
    and tooling. Changes in the test invocation considerations and
    runtime assumptions.
  - .contrib: Stuff that affects the contributor experience. e.g.
    Running tests, building the docs, setting up the development
    environment.
  - .misc: Changes that are hard to assign to any of the above
    categories.
- Make sure to use full sentences with correct case and punctuation,
  for example:
```
Fixed issue with non-ascii contents in doctest text files
-- by :user:`contributor-gh-handle`.
```
  Use the past tense or the present tense a non-imperative mood,
  referring to what's changed compared to the last released version
  of this project.

codspeed-hq · 2024-12-10T21:35:01Z

CodSpeed Performance Report

Merging #10154 will not alter performance

_{Comparing cdce8p:strict-bytes (526b54f) with master (7f8e2d3)}

Summary

✅ 47 untouched benchmarks

codecov · 2024-12-10T21:45:27Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.75%. Comparing base (7f8e2d3) to head (526b54f).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #10154   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files         122      122           
  Lines       36954    36954           
  Branches     4411     4411           
=======================================
  Hits        36494    36494           
  Misses        313      313           
  Partials      147      147

Flag	Coverage Δ
CI-GHA	`98.64% <100.00%> (ø)`
OS-Linux	`98.33% <100.00%> (ø)`
OS-Windows	`96.17% <100.00%> (ø)`
OS-macOS	`97.44% <100.00%> (+<0.01%)`	⬆️
Py-3.10.11	`97.27% <100.00%> (ø)`
Py-3.10.15	`97.81% <100.00%> (-0.06%)`	⬇️
Py-3.11.10	`97.86% <100.00%> (ø)`
Py-3.11.9	`97.33% <100.00%> (-0.01%)`	⬇️
Py-3.12.7	`98.38% <100.00%> (ø)`
Py-3.13.0	`97.19% <100.00%> (-0.01%)`	⬇️
Py-3.13.1	`98.35% <100.00%> (ø)`
Py-3.9.13	`97.20% <100.00%> (+<0.01%)`	⬆️
Py-3.9.20	`97.77% <100.00%> (ø)`
Py-pypy7.3.16	`97.34% <100.00%> (-0.01%)`	⬇️
VM-macos	`97.44% <100.00%> (+<0.01%)`	⬆️
VM-ubuntu	`98.33% <100.00%> (ø)`
VM-windows	`96.17% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGES/10154.bugfix.rst

Co-authored-by: J. Nick Koston <[email protected]>

CHANGES/10154.bugfix.rst

asvetlov

Thanks!

patchback · 2024-12-11T10:40:29Z

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/3f07b1a38beffc350adbf51a605d27fe306de66c/pr-10154

Backported as #10157

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

## What do these changes do? Mypy will add a `--strict-bytes` flag. python/mypy#18263 With that `bytearray` and `memoryview` are no longer subclasses of `bytes` and must be listed explicitly instead if they are supported. ## Are there changes in behavior for the user? -- ## Related issue number -- ## Checklist - [ ] I think the code is well written - [ ] Unit tests for the changes exist - [ ] Documentation reflects the changes - [ ] If you provide code modification, please add yourself to `CONTRIBUTORS.txt` * The format is <Name> <Surname>. * Please keep alphabetical order, the file is sorted by names. - [ ] Add a new news fragment into the `CHANGES/` folder * name it `<issue_or_pr_num>.<type>.rst` (e.g. `588.bugfix.rst`) * if you don't have an issue number, change it to the pull request number after creating the PR * `.bugfix`: A bug fix for something the maintainers deemed an improper undesired behavior that got corrected to match pre-agreed expectations. * `.feature`: A new behavior, public APIs. That sort of stuff. * `.deprecation`: A declaration of future API removals and breaking changes in behavior. * `.breaking`: When something public is removed in a breaking way. Could be deprecated in an earlier release. * `.doc`: Notable updates to the documentation structure or build process. * `.packaging`: Notes for downstreams about unobvious side effects and tooling. Changes in the test invocation considerations and runtime assumptions. * `.contrib`: Stuff that affects the contributor experience. e.g. Running tests, building the docs, setting up the development environment. * `.misc`: Changes that are hard to assign to any of the above categories. * Make sure to use full sentences with correct case and punctuation, for example: ```rst Fixed issue with non-ascii contents in doctest text files -- by :user:`contributor-gh-handle`. ``` Use the past tense or the present tense a non-imperative mood, referring to what's changed compared to the last released version of this project. --------- Co-authored-by: J. Nick Koston <[email protected]> (cherry picked from commit 3f07b1a)

patchback · 2024-12-11T10:40:38Z

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/3f07b1a38beffc350adbf51a605d27fe306de66c/pr-10154

Backported as #10158

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

## What do these changes do? Mypy will add a `--strict-bytes` flag. python/mypy#18263 With that `bytearray` and `memoryview` are no longer subclasses of `bytes` and must be listed explicitly instead if they are supported. ## Are there changes in behavior for the user? -- ## Related issue number -- ## Checklist - [ ] I think the code is well written - [ ] Unit tests for the changes exist - [ ] Documentation reflects the changes - [ ] If you provide code modification, please add yourself to `CONTRIBUTORS.txt` * The format is <Name> <Surname>. * Please keep alphabetical order, the file is sorted by names. - [ ] Add a new news fragment into the `CHANGES/` folder * name it `<issue_or_pr_num>.<type>.rst` (e.g. `588.bugfix.rst`) * if you don't have an issue number, change it to the pull request number after creating the PR * `.bugfix`: A bug fix for something the maintainers deemed an improper undesired behavior that got corrected to match pre-agreed expectations. * `.feature`: A new behavior, public APIs. That sort of stuff. * `.deprecation`: A declaration of future API removals and breaking changes in behavior. * `.breaking`: When something public is removed in a breaking way. Could be deprecated in an earlier release. * `.doc`: Notable updates to the documentation structure or build process. * `.packaging`: Notes for downstreams about unobvious side effects and tooling. Changes in the test invocation considerations and runtime assumptions. * `.contrib`: Stuff that affects the contributor experience. e.g. Running tests, building the docs, setting up the development environment. * `.misc`: Changes that are hard to assign to any of the above categories. * Make sure to use full sentences with correct case and punctuation, for example: ```rst Fixed issue with non-ascii contents in doctest text files -- by :user:`contributor-gh-handle`. ``` Use the past tense or the present tense a non-imperative mood, referring to what's changed compared to the last released version of this project. --------- Co-authored-by: J. Nick Koston <[email protected]> (cherry picked from commit 3f07b1a)

…ation for strict-bytes (#10157) **This is a backport of PR #10154 as merged into master (3f07b1a).** ## What do these changes do? Mypy will add a `--strict-bytes` flag. python/mypy#18263 With that `bytearray` and `memoryview` are no longer subclasses of `bytes` and must be listed explicitly instead if they are supported. ## Are there changes in behavior for the user? -- ## Related issue number -- ## Checklist - [ ] I think the code is well written - [ ] Unit tests for the changes exist - [ ] Documentation reflects the changes - [ ] If you provide code modification, please add yourself to `CONTRIBUTORS.txt` * The format is <Name> <Surname>. * Please keep alphabetical order, the file is sorted by names. - [ ] Add a new news fragment into the `CHANGES/` folder * name it `<issue_or_pr_num>.<type>.rst` (e.g. `588.bugfix.rst`) * if you don't have an issue number, change it to the pull request number after creating the PR * `.bugfix`: A bug fix for something the maintainers deemed an improper undesired behavior that got corrected to match pre-agreed expectations. * `.feature`: A new behavior, public APIs. That sort of stuff. * `.deprecation`: A declaration of future API removals and breaking changes in behavior. * `.breaking`: When something public is removed in a breaking way. Could be deprecated in an earlier release. * `.doc`: Notable updates to the documentation structure or build process. * `.packaging`: Notes for downstreams about unobvious side effects and tooling. Changes in the test invocation considerations and runtime assumptions. * `.contrib`: Stuff that affects the contributor experience. e.g. Running tests, building the docs, setting up the development environment. * `.misc`: Changes that are hard to assign to any of the above categories. * Make sure to use full sentences with correct case and punctuation, for example: ```rst Fixed issue with non-ascii contents in doctest text files -- by :user:`contributor-gh-handle`. ``` Use the past tense or the present tense a non-imperative mood, referring to what's changed compared to the last released version of this project. Co-authored-by: Marc Mueller <[email protected]>

…ation for strict-bytes (#10158) **This is a backport of PR #10154 as merged into master (3f07b1a).** ## What do these changes do? Mypy will add a `--strict-bytes` flag. python/mypy#18263 With that `bytearray` and `memoryview` are no longer subclasses of `bytes` and must be listed explicitly instead if they are supported. ## Are there changes in behavior for the user? -- ## Related issue number -- ## Checklist - [ ] I think the code is well written - [ ] Unit tests for the changes exist - [ ] Documentation reflects the changes - [ ] If you provide code modification, please add yourself to `CONTRIBUTORS.txt` * The format is <Name> <Surname>. * Please keep alphabetical order, the file is sorted by names. - [ ] Add a new news fragment into the `CHANGES/` folder * name it `<issue_or_pr_num>.<type>.rst` (e.g. `588.bugfix.rst`) * if you don't have an issue number, change it to the pull request number after creating the PR * `.bugfix`: A bug fix for something the maintainers deemed an improper undesired behavior that got corrected to match pre-agreed expectations. * `.feature`: A new behavior, public APIs. That sort of stuff. * `.deprecation`: A declaration of future API removals and breaking changes in behavior. * `.breaking`: When something public is removed in a breaking way. Could be deprecated in an earlier release. * `.doc`: Notable updates to the documentation structure or build process. * `.packaging`: Notes for downstreams about unobvious side effects and tooling. Changes in the test invocation considerations and runtime assumptions. * `.contrib`: Stuff that affects the contributor experience. e.g. Running tests, building the docs, setting up the development environment. * `.misc`: Changes that are hard to assign to any of the above categories. * Make sure to use full sentences with correct case and punctuation, for example: ```rst Fixed issue with non-ascii contents in doctest text files -- by :user:`contributor-gh-handle`. ``` Use the past tense or the present tense a non-imperative mood, referring to what's changed compared to the last released version of this project. Co-authored-by: Marc Mueller <[email protected]>

cdce8p requested review from webknjaz and asvetlov as code owners December 10, 2024 21:25

psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Dec 10, 2024

cdce8p added backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Dec 10, 2024

cdce8p force-pushed the strict-bytes branch from 1030b03 to 562ac50 Compare December 10, 2024 21:28

Update StreamResponse.write annotation for strict-bytes

1b36bea

cdce8p force-pushed the strict-bytes branch from 562ac50 to 1b36bea Compare December 10, 2024 21:37

bdraco reviewed Dec 10, 2024

View reviewed changes

CHANGES/10154.bugfix.rst Outdated Show resolved Hide resolved

Update CHANGES/10154.bugfix.rst

f362a8b

Co-authored-by: J. Nick Koston <[email protected]>

bdraco reviewed Dec 10, 2024

View reviewed changes

CHANGES/10154.bugfix.rst Outdated Show resolved Hide resolved

Add cross references to the Python docs

526b54f

bdraco approved these changes Dec 10, 2024

View reviewed changes

asvetlov approved these changes Dec 11, 2024

View reviewed changes

asvetlov merged commit 3f07b1a into aio-libs:master Dec 11, 2024
40 checks passed

patchback bot mentioned this pull request Dec 11, 2024

[PR #10154/3f07b1a3 backport][3.11] Update StreamResponse.write annotation for strict-bytes #10157

Merged

5 tasks

patchback bot mentioned this pull request Dec 11, 2024

[PR #10154/3f07b1a3 backport][3.12] Update StreamResponse.write annotation for strict-bytes #10158

Merged

5 tasks

cdce8p deleted the strict-bytes branch December 11, 2024 10:42

cdce8p mentioned this pull request Dec 16, 2024

Update mypy-dev to 1.14.0a7 home-assistant/core#133390

Merged

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update StreamResponse.write annotation for strict-bytes #10154

Update StreamResponse.write annotation for strict-bytes #10154

cdce8p commented Dec 10, 2024 •

edited

Loading

codspeed-hq bot commented Dec 10, 2024 •

edited

Loading

codecov bot commented Dec 10, 2024 •

edited

Loading

asvetlov left a comment

patchback bot commented Dec 11, 2024 •

edited

Loading

patchback bot commented Dec 11, 2024 •

edited

Loading

Update StreamResponse.write annotation for strict-bytes #10154

Update StreamResponse.write annotation for strict-bytes #10154

Conversation

cdce8p commented Dec 10, 2024 • edited Loading

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

codspeed-hq bot commented Dec 10, 2024 • edited Loading

CodSpeed Performance Report

Merging #10154 will not alter performance

Summary

codecov bot commented Dec 10, 2024 • edited Loading

Codecov Report

asvetlov left a comment

Choose a reason for hiding this comment

patchback bot commented Dec 11, 2024 • edited Loading

Backport to 3.11: 💚 backport PR created

patchback bot commented Dec 11, 2024 • edited Loading

Backport to 3.12: 💚 backport PR created

cdce8p commented Dec 10, 2024 •

edited

Loading

codspeed-hq bot commented Dec 10, 2024 •

edited

Loading

codecov bot commented Dec 10, 2024 •

edited

Loading

patchback bot commented Dec 11, 2024 •

edited

Loading

patchback bot commented Dec 11, 2024 •

edited

Loading