Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host parameter to aiohttp_server fixture (#10120) (#10121) #10150

Conversation

Dreamsorcerer
Copy link
Member

Co-authored-by: ChristianWBrock <christian.brock AT posteo.net>
(cherry picked from commit 7f8e2d3)

Co-authored-by: ChristianWBrock <christian.brock AT posteo.net>
(cherry picked from commit 7f8e2d3)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Dec 9, 2024
Copy link

codspeed-hq bot commented Dec 9, 2024

CodSpeed Performance Report

Merging #10150 will not alter performance

Comparing patchback/backports/3.12/7f8e2d35ad4d0d5fed82721060bafd1bafa264b8/pr-10121 (534dc09) with 3.12 (eb42db8)

Summary

✅ 47 untouched benchmarks

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (eb42db8) to head (534dc09).
Report is 1 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.12   #10150   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         123      123           
  Lines       37139    37139           
  Branches     4468     4468           
=======================================
  Hits        36419    36419           
  Misses        542      542           
  Partials      178      178           
Flag Coverage Δ
CI-GHA 97.95% <100.00%> (ø)
OS-Linux 97.65% <100.00%> (-0.01%) ⬇️
OS-Windows 94.57% <100.00%> (ø)
OS-macOS 96.77% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.62% <100.00%> (-0.01%) ⬇️
Py-3.10.15 97.16% <100.00%> (ø)
Py-3.11.10 97.23% <100.00%> (ø)
Py-3.11.9 96.70% <100.00%> (-0.01%) ⬇️
Py-3.12.7 97.71% <100.00%> (ø)
Py-3.13.0 96.55% <100.00%> (ø)
Py-3.13.1 97.68% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.55% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.13% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.69% <100.00%> (-0.01%) ⬇️
VM-macos 96.77% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.65% <100.00%> (-0.01%) ⬇️
VM-windows 94.57% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 51cdda8 into 3.12 Dec 9, 2024
36 checks passed
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.12/7f8e2d35ad4d0d5fed82721060bafd1bafa264b8/pr-10121 branch December 9, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants