[PR #10102/7557b03d backport][3.11] Fix deprecated calls to guess_type for paths with Python 3.13
#10103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
(cherry picked from commit 7557b03)
bdraco
approved these changes
Dec 4, 2024
CodSpeed Performance ReportMerging #10103 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.11 #10103 +/- ##
==========================================
- Coverage 98.06% 98.06% -0.01%
==========================================
Files 123 123
Lines 37090 37098 +8
Branches 4457 4459 +2
==========================================
+ Hits 36374 36381 +7
Misses 540 540
- Partials 176 177 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
deleted the
patchback/backports/3.11/7557b03da53a51a21dbd66ee8206755fdcd0d728/pr-10102
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #10102 as merged into master (7557b03).
What do these changes do?
https://docs.python.org/3/library/mimetypes.html#mimetypes.guess_type
These should have been changed to
guess_file_typeon Python 3.13 asguess_typeexpects a URL andguess_file_typeexpects a path. Its a soft deprecation so they still work but that may change in the future.Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no