Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #10037/2e369db backport][3.12] Refactor requests and responses to use classvar defaults to avoid multiple __init__s #10054

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 26, 2024

(cherry picked from commit 2e369db)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 26, 2024
@bdraco bdraco changed the title Refactor requests and responses to use classvar defaults to avoid multiple __init__s (#10037) [PR #10037/2e369db backport][3.12] Refactor requests and responses to use classvar defaults to avoid multiple __init__s Nov 26, 2024
@bdraco bdraco marked this pull request as ready for review November 26, 2024 23:55
Copy link

codspeed-hq bot commented Nov 26, 2024

CodSpeed Performance Report

Merging #10054 will improve performances by 15.5%

Comparing patchback/backports/3.12/2e369db2d9abcbef41031592b4f044adf5f89f59/pr-10037 (8e5482e) with 3.12 (c9eb8e7)

Summary

⚡ 1 improvements
✅ 43 untouched benchmarks

Benchmarks breakdown

Benchmark 3.12 patchback/backports/3.12/2e369db2d9abcbef41031592b4f044adf5f89f59/pr-10037 Change
test_simple_web_stream_response 318.7 µs 276 µs +15.5%

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (c9eb8e7) to head (8e5482e).
Report is 1 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.12   #10054      +/-   ##
==========================================
+ Coverage   96.38%   98.03%   +1.65%     
==========================================
  Files         120      122       +2     
  Lines       36865    36931      +66     
  Branches     4424     4448      +24     
==========================================
+ Hits        35533    36207     +674     
+ Misses       1073      543     -530     
+ Partials      259      181      -78     
Flag Coverage Δ
CI-GHA 97.93% <100.00%> (+1.54%) ⬆️
OS-Linux 97.63% <100.00%> (?)
OS-Windows 94.53% <100.00%> (?)
OS-macOS 96.74% <100.00%> (+0.35%) ⬆️
Py-3.10.11 96.60% <100.00%> (?)
Py-3.10.15 97.19% <100.00%> (?)
Py-3.11.10 97.25% <100.00%> (?)
Py-3.11.9 96.67% <100.00%> (+0.28%) ⬆️
Py-3.12.7 97.70% <100.00%> (?)
Py-3.13.0 97.68% <100.00%> (?)
Py-3.9.13 96.53% <100.00%> (?)
Py-3.9.20 97.10% <100.00%> (?)
Py-pypy7.3.16 96.67% <100.00%> (?)
VM-macos 96.74% <100.00%> (+0.35%) ⬆️
VM-ubuntu 97.63% <100.00%> (?)
VM-windows 94.53% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) November 27, 2024 00:00
@bdraco bdraco merged commit e5dd82a into 3.12 Nov 27, 2024
34 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/2e369db2d9abcbef41031592b4f044adf5f89f59/pr-10037 branch November 27, 2024 00:04
bdraco added a commit that referenced this pull request Nov 30, 2024
bdraco added a commit that referenced this pull request Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant