-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce initialization overhead in ClientResponse
#10030
Conversation
CodSpeed Performance ReportMerging #10030 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #10030 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 121 121
Lines 36747 36754 +7
Branches 4387 4388 +1
=======================================
+ Hits 36281 36289 +8
Misses 314 314
+ Partials 152 151 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ClientResponse
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply cdc01cd on top of patchback/backports/3.11/cdc01cde146fe4c38e6185b983747826cfbb0f6e/pr-10030 Backporting merged PR #10030 into master
🤖 @patchback |
Backport to 3.12: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply cdc01cd on top of patchback/backports/3.12/cdc01cde146fe4c38e6185b983747826cfbb0f6e/pr-10030 Backporting merged PR #10030 into master
🤖 @patchback |
(cherry picked from commit cdc01cd)
(cherry picked from commit cdc01cd)
Small speed up
When combined with #10029, its ~40% faster making
ClientResponse
objects