Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #10003/78d1be5 backport][3.11] Fix client connection header not reflecting connector force_close value #10009

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 20, 2024

(cherry picked from commit 78d1be5)

@bdraco bdraco marked this pull request as draft November 20, 2024 21:28
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 20, 2024
@bdraco bdraco changed the title Fix client connection header not reflecting connector force_close value (#10003) [PR #10003/78d1be5 backport][3.11] Fix client connection header not reflecting connector force_close value Nov 20, 2024
@bdraco bdraco marked this pull request as ready for review November 20, 2024 21:34
Copy link

codspeed-hq bot commented Nov 20, 2024

CodSpeed Performance Report

Merging #10009 will improve performances by 8.71%

Comparing patchback/backports/3.11/78d1be5d79f67597313354646eec200ff603fd9d/pr-10003 (3f63185) with 3.11 (b235e76)

Summary

⚡ 1 improvements
✅ 42 untouched benchmarks

Benchmarks breakdown

Benchmark 3.11 patchback/backports/3.11/78d1be5d79f67597313354646eec200ff603fd9d/pr-10003 Change
test_send_client_request_one_hundred[pyloop] 3.1 ms 2.8 ms +8.71%

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (3.11@d030c05). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11   #10009   +/-   ##
=======================================
  Coverage        ?   98.03%           
=======================================
  Files           ?      122           
  Lines           ?    36889           
  Branches        ?     4440           
=======================================
  Hits            ?    36163           
  Misses          ?      543           
  Partials        ?      183           
Flag Coverage Δ
CI-GHA 97.92% <100.00%> (?)
OS-Linux 97.63% <100.00%> (?)
OS-Windows 94.52% <100.00%> (?)
OS-macOS 96.74% <100.00%> (?)
Py-3.10.11 96.59% <100.00%> (?)
Py-3.10.15 97.17% <100.00%> (?)
Py-3.11.10 97.20% <100.00%> (?)
Py-3.11.9 96.66% <100.00%> (?)
Py-3.12.7 97.69% <100.00%> (?)
Py-3.13.0 97.64% <100.00%> (?)
Py-3.9.13 96.52% <100.00%> (?)
Py-3.9.20 97.09% <100.00%> (?)
Py-pypy7.3.16 96.66% <100.00%> (?)
VM-macos 96.74% <100.00%> (?)
VM-ubuntu 97.63% <100.00%> (?)
VM-windows 94.52% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) November 20, 2024 22:10
@bdraco bdraco merged commit c82c58a into 3.11 Nov 20, 2024
34 of 35 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/78d1be5d79f67597313354646eec200ff603fd9d/pr-10003 branch November 20, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant