-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid building skip_headers
in ClientSession._request
if it will be thrown away
#10004
Conversation
skip_headers
in ClientSession._request if it will be thrown away
skip_headers
in ClientSession._request if it will be thrown awayskip_headers
in ClientSession._request
if it will be thrown away
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #10004 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 121 121
Lines 36738 36739 +1
Branches 4384 4385 +1
=======================================
+ Hits 36272 36273 +1
Misses 314 314
Partials 152 152
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #10004 will not alter performanceComparing Summary
|
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #10005 🤖 @patchback |
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #10006 🤖 @patchback |
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #10007 🤖 @patchback |
…`ClientSession._request` if it will be thrown away (#10005) Co-authored-by: J. Nick Koston <[email protected]>
…`ClientSession._request` if it will be thrown away (#10006) Co-authored-by: J. Nick Koston <[email protected]>
…`ClientSession._request` if it will be thrown away (#10007) Co-authored-by: J. Nick Koston <[email protected]>
There is a very good chance that we will build
skip_headers
and than throw it away as this option is not commonly passed.