Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid building skip_headers in ClientSession._request if it will be thrown away #10004

Merged
merged 8 commits into from
Nov 20, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 20, 2024

There is a very good chance that we will build skip_headers and than throw it away as this option is not commonly passed.

@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.10 backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Nov 20, 2024
@bdraco bdraco changed the title Avoid building skip_headers in ClientSession._request if it will be thrown away Avoid building skip_headers in ClientSession._request if it will be thrown away Nov 20, 2024
@bdraco bdraco changed the title Avoid building skip_headers in ClientSession._request if it will be thrown away Avoid building skip_headers in ClientSession._request if it will be thrown away Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (af33a82) to head (b56766f).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10004   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         121      121           
  Lines       36738    36739    +1     
  Branches     4384     4385    +1     
=======================================
+ Hits        36272    36273    +1     
  Misses        314      314           
  Partials      152      152           
Flag Coverage Δ
CI-GHA 98.62% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.30% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.13% <ø> (ø)
OS-macOS 97.39% <100.00%> (-0.02%) ⬇️
Py-3.10.11 97.24% <100.00%> (-0.01%) ⬇️
Py-3.10.15 97.84% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 97.84% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 95.74% <ø> (-1.58%) ⬇️
Py-3.12.7 98.36% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 98.36% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.17% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.75% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 97.32% <100.00%> (+<0.01%) ⬆️
VM-macos 97.39% <100.00%> (-0.02%) ⬇️
VM-ubuntu 98.30% <100.00%> (+<0.01%) ⬆️
VM-windows 96.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Nov 20, 2024

CodSpeed Performance Report

Merging #10004 will not alter performance

Comparing skip_headers (b56766f) with master (af33a82)

Summary

✅ 43 untouched benchmarks

aiohttp/client.py Outdated Show resolved Hide resolved
@bdraco bdraco marked this pull request as ready for review November 20, 2024 21:22
@bdraco bdraco requested a review from asvetlov as a code owner November 20, 2024 21:22
@bdraco bdraco merged commit a334eef into master Nov 20, 2024
40 of 41 checks passed
@bdraco bdraco deleted the skip_headers branch November 20, 2024 21:22
Copy link
Contributor

patchback bot commented Nov 20, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/a334eef76c198746b8f02e9a8a89f083a918f076/pr-10004

Backported as #10005

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Nov 20, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/a334eef76c198746b8f02e9a8a89f083a918f076/pr-10004

Backported as #10006

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Nov 20, 2024

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/a334eef76c198746b8f02e9a8a89f083a918f076/pr-10004

Backported as #10007

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

bdraco added a commit that referenced this pull request Nov 20, 2024
…`ClientSession._request` if it will be thrown away (#10005)

Co-authored-by: J. Nick Koston <[email protected]>
bdraco added a commit that referenced this pull request Nov 20, 2024
…`ClientSession._request` if it will be thrown away (#10006)

Co-authored-by: J. Nick Koston <[email protected]>
bdraco added a commit that referenced this pull request Nov 20, 2024
…`ClientSession._request` if it will be thrown away (#10007)

Co-authored-by: J. Nick Koston <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant