Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look into zero copy writes for the websocket writer #9633

Closed
bdraco opened this issue Nov 3, 2024 · 2 comments · May be fixed by #9634
Closed

Look into zero copy writes for the websocket writer #9633

bdraco opened this issue Nov 3, 2024 · 2 comments · May be fixed by #9634
Assignees
@bdraco

Comments

@bdraco
Copy link
Member

bdraco commented Nov 3, 2024

aiohttp/aiohttp/_websocket/writer.py

Line 138 in c95c025

self.transport.write(header + mask + message)

in python 3.12+ writelines does zero copy
@bdraco bdraco self-assigned this Nov 3, 2024
@bdraco
Copy link
Member Author

bdraco commented Nov 3, 2024

python/cpython#91166

Picows has a good benchmark to see if it matters

bdraco added a commit that referenced this issue Nov 3, 2024
@bdraco
Implement zerocopy writes for the WebSocket writer
1ad30e9 
closes #9633
@bdraco bdraco mentioned this issue Nov 3, 2024
Draft
bdraco added a commit that referenced this issue Nov 3, 2024
@bdraco
Implement zerocopy writes for the WebSocket writer
126667f 
closes #9633
@bdraco
Copy link
Member Author

bdraco commented Nov 5, 2024

#9634 still showed too much memcpy.... It should have been less so not sure why. Closing this

@bdraco bdraco closed this as not planned Won't fix, can't repro, duplicate, stale Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdraco bdraco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement zero copy writes for the WebSocket writer aio-libs/aiohttp
1 participant
@bdraco