Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test suite warnings on FreeBSD: ResourceWarning / DeprecationWarning #92

Closed
koobs opened this issue Jul 1, 2014 · 4 comments
Closed

Test suite warnings on FreeBSD: ResourceWarning / DeprecationWarning #92

koobs opened this issue Jul 1, 2014 · 4 comments
Labels
outdated

Comments

@koobs
Copy link

koobs commented Jul 1, 2014

Noted 3 test warnings while updating the aiohttp FreeBSD port:

FreeBSD: 9.2-STABLE r264519 (FreeBSD 9.x)
Python: 3.3.5
aiohttp: 0.8.2
asyncio: 3.4.1

test_del (test_client.ClientResponseTests) ... /mnt/home/user/repos/freebsd/ports/www/py-aiohttp/work/aiohttp-0.8.2/aiohttp/client.py:592: ResourceWarning: ClientResponse has to be closed explicitly! get::http://python.org
  warnings.warn(msg, ResourceWarning)
ok

test_dont_close_explicit_connector (test_client_functional.HttpClientFunctionalTests) ... /mnt/home/user/repos/freebsd/ports/www/py-aiohttp/work/aiohttp-0.8.2/tests/test_client_functional.py:28: ResourceWarning: unclosed <socket.socket object, $
d=10, family=2, type=1, proto=6>
  gc.collect()
ok

test_session_cookies (test_client_functional.HttpClientFunctionalTests) ... /mnt/home/user/repos/freebsd/ports/www/py-aiohttp/work/aiohttp-0.8.2/aiohttp/client.py:634: DeprecationWarning: The 'warn' function is deprecated, use 'warning' instead
  logging.warn('Can not load response cookies: %s', exc)
ok

Ran 390 tests in 2.977s - OK
@asvetlov
Copy link
Member

asvetlov commented Jul 2, 2014

I've fixed the first and the last on master.

@fafhrd91
Copy link
Member

fafhrd91 commented Jul 6, 2014

can not reproduce anymore.

@fafhrd91 fafhrd91 closed this as completed Jul 6, 2014
@koobs
Copy link
Author

koobs commented Jul 6, 2014

Confirmed in 0.8.4:

  • test_del (test_client.ClientResponseTests) ... ok
  • test_dont_close_explicit_connector (test_client_functional.HttpClientFunctionalTests) ... ok
  • test_session_cookies (test_client_functional.HttpClientFunctionalTests) ... ok

Ran 403 tests in 3.447s - OK

koobs added a commit to freebsd/freebsd-ports that referenced this issue Jul 7, 2014
@koobs
www/py-aiohttp: Update to 0.8.4
4073b27 
- Update to 0.8.4
- Includes fixes to test suite warnings [1]

Changes:

  https://github.com/KeepSafe/aiohttp/blob/v0.8.4/CHANGES.txt

[1] aio-libs/aiohttp#92
splbio pushed a commit to splbio/freebsd-ports that referenced this issue Nov 24, 2014
www/py-aiohttp: Update to 0.8.4
1fd00de 
- Update to 0.8.4
- Includes fixes to test suite warnings [1]

Changes:

  https://github.com/KeepSafe/aiohttp/blob/v0.8.4/CHANGES.txt

[1] aio-libs/aiohttp#92


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@361016 35697150-7ecd-e111-bb59-0022644237b5
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asvetlov @fafhrd91 @koobs