-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push new release to pypi #5366
Comments
We have the same issue as @bannsec at https://github.com/Drakkar-Software/OctoBot. |
I can see this is already fixed in 3.8, so you're just waiting for the next release to be made. |
Is there any timeline for this? Came here as Chardet is flagged up as an outdated package for us and this is the only thing I can see blocking it. |
Is there a schedule for the release @webknjaz ? Thanks ! |
Using sopel-irc/docker-sopel#37 temporary fix We should remove this fix when aio-libs/aiohttp#5366 is resolved
Using sopel-irc/docker-sopel#37 temporary fix We should remove this fix when aio-libs/aiohttp#5366 is resolved
Using sopel-irc/docker-sopel#37 temporary fix We should remove this fix when aio-libs/aiohttp#5366 is resolved
Bump, lots of issues now, a release would be spectacular. |
This issue has been mentioned on aio-libs. There might be relevant details there: |
There's no formal release schedule but I will try to look into it over the weekend. |
Thank you very much for your reponse. Funkwhale currently has an encoding bug with podcasts which is tracked here: https://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/1299 . A release would be much appreciated. |
Hello, I am currently planning a release for Funkwhale and the issue linked in the previous comment is one of our last issues. Do you already have a schedule for the next release? |
I had to make a security release in the 3.7 stream so I piggy-backed a #5333 backport on top of it and it should be available in v3.7.4. |
@Dreamsorcerer 3.7 stream is supposed to be closed. The only reason I released 3.7.4 was a CVE and that the branch of 3.8 is in a bad shape (I haven't compared even the features it has with 3.7). It would require a lot more mental capacity and time to release 3.8. Also, it's hard to support many release streams. First thing to do is to make the CI green because the release process won't get through if testing fails. Then, somebody needs to look at the diff and try to assess whether there's no obvious problems + look at the changelog. |
3.7.4 is still forcing chardet < 4.0 |
Ouch... Looks like only a part of that patch got backported (4ed7c25) and I did not verify it separately because the release was security-focused. Maybe this happened because of the rebases I had to do due to the bug that prevented the release. Sorry about that! |
Can we reopen this issue in this case, please? |
As you made us so happy with the suggestion it might be fixed in 3.7.4, any chance you can throw in a quick 3.7.5 to fix it? :D (honestly, I fully understand if you cannot, and it really is okay; it just means a bit more work on my side every month to keep |
@TrueBrain I've had a minute to make the post-release @ https://pypi.org/project/aiohttp/3.7.4.post0/ — enjoy! |
How absolutely awesome, thank you so much for that :D You rule :D |
The previous package is not compatible with chardet 4.0.0 which was updated in 9ed4286, see aio-libs/aiohttp#5366
🐣 Is your feature request related to a problem? Please describe.
Yes. When attempting to build a discord.py application today, i've discovered aiohttp is causing a dependency issue which is causing my bot to not work anymore.
💡 Describe the solution you'd like
it appears this was fixed in master about 12 days ago. However, i need that change in pypi for my bot to build.
❓ Describe alternatives you've considered
📋 Additional context
The text was updated successfully, but these errors were encountered: