Request header "Content-Type: application/json; charset=test" cause an error

[Pentusha]

Long story short

Request's header Content-Type encoding have not validated properly.
bytes_body.decode(encoding) raise as error "LookupError: unknown encoding: test"

Expected behaviour

Status code 415 or 422
Encoding have to be limited with standard encodings.

Actual behaviour

500 Internal Server Error

Server got itself in trouble

Error handling request
Traceback (most recent call last):
  File "/home/pentusha/.venvs/test/lib/python3.7/site-packages/aiohttp/web_protocol.py", line 418, in start
    resp = await task
  File "/home/pentusha/.venvs/test/lib/python3.7/site-packages/aiohttp/web_app.py", line 458, in _handle
    resp = await handler(request)
  File "/home/pentusha/projects/test/api/app2.py", line 5, in post_handler
    body = await request.text()
  File "/home/pentusha/.venvs/test/lib/python3.7/site-packages/aiohttp/web_request.py", line 579, in text
    return bytes_body.decode(encoding)
LookupError: unknown encoding: test

Steps to reproduce

from aiohttp import web

async def post_handler(request):
    body = await request.text()
    return web.Response(body)

def main():
    app = web.Application()
    app.add_routes([
        web.post('/', post_handler)
    ])
    web.run_app(app, host='0.0.0.0', port=8000)

if __name__ == '__main__':
    main()

curl 'http://0:8000/' -H 'Content-Type: application/json; charset=test' -d '{}'

Your environment

aiohttp==3.5.4
Python 3.7.0

[aio-libs-bot]

GitMate.io thinks the contributor most likely able to help you is @asvetlov.

Possibly related issues are #1011 (POST with application/json headers), #3242 (Error), #2206 (json request for certain media types fail), #2120 (Invalid content-type header causes LookupError), and #1197 (Flask request headers).

[asvetlov]

Thanks for the report.
415 looks good probably.
Would you make a pull request?

[socketpair]

Agree, 415 is appropriate

[asvetlov]

Fixed by #3564