-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracing support enhancements #3084
Comments
Thank you very much for the feedback.
Agree, we need it.
Maybe we need to move sending
I suspect this private API will be changed soon.
Please elaborate. Are you request for a new signal for composing these three?
Discussed above.
A response is received after sending a request. What exactly confuses you? |
Ideally any network related delay would be traceable. It would be neat if this was lower level in core python but what can we do :) I think the closer to bare metal the better. In ddtrace we want to know how long it took to read from the stream. I think right now I capture the sending via the overall request length however it's not critical to have because I think that typically doesn't take a long time.
It's not really necessary, I have enough information from the other traces and what we're discussing.
the part that's confusing is that you have a Thanks! |
@thehesiod would you work on the issue? I see a strong request for a signal that is raised when response headers are received. Sorry, I cannot spend much time by hacking aiohttp now at least up to the end of May (Python 3.8 feature freeze date) plus realistically I will be busy on writing documentation and fixing bugs even after the beta release. P.S.
Anyway, I'm starting to return to active FOSS development. The next Python is my the first target, the next is aiohttp (maybe with stops on multidict and yarl, both libraries need my love too). |
Welcome to the baby club :) today our son was shrieking all day :). I'll try too, this year has been crazy |
Long story short
After writing an ugly 2.x monkeypatch for client tracing support in datadog: DataDog/dd-trace-py#294 a new aiohttp tracing strategy was discussed and created. I'm now trying to move this PR to use the new tracing support however have run into a few issues.
Expected behaviour
Ability to trace major network activities in aiohttp
Actual behaviour
StreamReader.read()
Steps to reproduce
TBD
Your environment
aiohttp 3.3.1
Other Thoughts from a client perspective
send_response_chunk_received
represents? It would be nice if there was a diagram describing when each one happens.send_request_chunk_sent
w/o a received, basically sending request but never got response? What I see on a request from aiobotocore is: send_request_start -> send_conn_create_start -> send_conn_create_end -> send_request_chunk_sent -> send_request_endThe text was updated successfully, but these errors were encountered: