Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process urls like https://user:[email protected] #2243

Closed
asvetlov opened this issue Sep 5, 2017 · 6 comments
Closed

Process urls like https://user:[email protected] #2243

asvetlov opened this issue Sep 5, 2017 · 6 comments
Labels

Comments

@asvetlov
Copy link
Member

asvetlov commented Sep 5, 2017

Extract user info from URL and construct proper auth header.

@sashgorokhov
Copy link

If you dont mind, I am going to implement this and provide a pull request

@asvetlov
Copy link
Member Author

asvetlov commented Oct 4, 2017

Please do

@sashgorokhov
Copy link

Seems like this is already implemented.
There is a function aiohttp.client_reqrep.ClientRequest.update_host which creates a aiohttp.helpers.BasicAuth with username and password specified in url. Works on both http and https schemes.

@asvetlov
Copy link
Member Author

asvetlov commented Oct 4, 2017

Yep, I see.
Anyway, it would be nice to move the functionality into ClientSession._request.
Consider it as preparation for #2019

@sashgorokhov
Copy link

Ok, I'll see what i can do

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants