Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest: add Access Logging option to show X-Forwarded-For #2123

Closed
harobed opened this issue Jul 23, 2017 · 4 comments
Closed

Suggest: add Access Logging option to show X-Forwarded-For #2123

harobed opened this issue Jul 23, 2017 · 4 comments
Labels
good first issue Good for newcomers outdated

Comments

@harobed
Copy link

harobed commented Jul 23, 2017 •
edited
Loading

Suggest: add Access Logging option to show X-Forwarded-For

Exemple %f option return X-Forwarded-For value or Remote IP-address if X-Forwarded-For don't exist.
@harobed harobed changed the title Suggest: add Access Logging option to show X_FORWARDED_HOST Suggest: add Access Logging option to show X-Forwarded-For Jul 23, 2017
harobed pushed a commit to harobed/aiohttp that referenced this issue Jul 23, 2017
@stephane-klein
Add X-Forward-For option to Access Log aio-libs#2123
410a361
@harobed harobed mentioned this issue Jul 23, 2017
Closed
@asvetlov
Copy link
Member

I suggest another change: pass request instead of message into AccessLogger.log (since aiohttp 2.0 web_protocol.RequestHandler always create a request instance.
In turn web.BaseRequest has req.host property, the property respects both Forwarded and X-FORWARDED-HOST headers.

@asvetlov
Copy link
Member

@harobed do you want to make a PR for implementing my proposal?

@harobed
Copy link
Author

harobed commented Jul 25, 2017

Yes, maybe this evening.

@asvetlov asvetlov added the good first issue Good for newcomers label Jul 26, 2017
asvetlov added a commit that referenced this issue Jul 29, 2017
@asvetlov
Fix #2123: User request instead of message in access logger
23d2c8a
@asvetlov asvetlov mentioned this issue Jul 29, 2017
Merged
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@harobed @asvetlov