Fix #1947: don't raise DeprecationWarning inside on_startup() handler…

… for test_utils
aio-libs · Jun 14, 2017 · ed28add · ed28add
1 parent acc0e26
commit ed28add
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -18,7 +18,8 @@ Changes
 
 - Use CIMultiDict for ClientRequest.skip_auto_headers #1970
 
--
+- Fix wrong startup sequence: test server doesn't raise
+  `DeprecationWarning` now #1947
 
 -
 

diff --git a/aiohttp/test_utils.py b/aiohttp/test_utils.py
@@ -148,8 +148,8 @@ def __init__(self, app, *,
 
     @asyncio.coroutine
     def _make_factory(self, **kwargs):
-        self.handler = self.app.make_handler(loop=self._loop, **kwargs)
         yield from self.app.startup()
+        self.handler = self.app.make_handler(loop=self._loop, **kwargs)
         return self.handler
 
     @asyncio.coroutine
-Original file line number
+Diff line change
@@ Expand Up / @@ -18,7 +18,8 @@ Changes @@
     - Use CIMultiDict for ClientRequest.skip_auto_headers #1970
-    -
+    - Fix wrong startup sequence: test server doesn't raise
+      `DeprecationWarning` now #1947
     -
@@ Expand Down @@