Make ClientResponse.history readonly property, update docs

aiohttp/client.py

@@ -223,7 +223,7 @@ def _request(self, method, url, *,
 
             break
 
-        resp.history = history
+        resp._history = tuple(history)
         return resp
 
     def ws_connect(self, url, *,

aiohttp/client_reqrep.py

@@ -512,7 +512,6 @@ class ClientResponse:
     cookies = None  # Response cookies (Set-Cookie)
     content = None  # Payload stream
     headers = None  # Response headers, CIMultiDictProxy
-    history = None  # List of responses, if redirects occured
 
     _connection = None  # current connection
     flow_control_class = FlowControlStreamReader  # reader flow control
@@ -535,6 +534,7 @@ def __init__(self, method, url, host='', *, writer=None, continue100=None):
         self._continue = continue100
         self._closed = False
         self._should_close = True  # override by message.should_close later
+        self._history = ()
 
     def _post_init(self, loop):
         self._loop = loop
@@ -565,6 +565,11 @@ def __repr__(self):
     def connection(self):
         return self._connection
 
+    @property
+    def history(self):
+        """A sequence of of responses, if redirects occured."""
+        return self._history
+
     def waiting_for_continue(self):
         return self._continue is not None
 

docs/client.rst

@@ -531,16 +531,16 @@ Response History
 ----------------
 
 If a request was redirected, it is possible to view previous responses using
-the history attribute::
+the :attr:`~ClientResponse.history` attribute::
 
     >>> r = await aiohttp.get('http://example.com/some/redirect/')
     >>> r
     <ClientResponse(http://example.com/some/other/url/) [200]>
     >>> r.history
-    [<ClientResponse(http://example.com/some/redirect/) [301]>]
+    (<ClientResponse(http://example.com/some/redirect/) [301]>,)
 
 If no redirects occured or ``allow_redirects`` is set to ``False``, history will
-be an empty list.
+be an empty sequence.
 
 
 Timeouts

docs/client_reference.rst

@@ -956,8 +956,9 @@ Response object
 
    .. attribute:: history
 
-      :class:`list` of :class:`ClientResponse` objects of preceding requests, if there
-      were redirects.
+      A :class:`~collections.abc.Sequence` of :class:`ClientResponse`
+      objects of preceding requests if there were redirects, an empty
+      sequence otherwise.
 
    .. method:: close()
 

tests/test_client_functional.py

@@ -351,7 +351,7 @@ def handler_ok(request):
 
     resp = yield from client.get('/ok')
     try:
-        assert resp.history == []
+        assert len(resp.history) == 0
         assert resp.status == 200
     finally:
         resp.release()