Adjust type annotations making print arg optional in web.run_app()

PR #3690 by @dutradda
aio-libs · Apr 13, 2019 · baddbfe · baddbfe
1 parent fc49f97
commit baddbfe
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/CHANGES/3690.misc b/CHANGES/3690.misc
@@ -0,0 +1 @@
+Do print argument optional on run_app function
diff --git a/CONTRIBUTORS.txt b/CONTRIBUTORS.txt
@@ -67,6 +67,7 @@ Denilson Amorim
 Denis Matiychuk
 Dima Veselov
 Dimitar Dimitrov
+Diogo Dutra da Mata
 Dmitriy Safonov
 Dmitry Doroshev
 Dmitry Lukashin

diff --git a/aiohttp/web.py b/aiohttp/web.py
@@ -265,7 +265,7 @@ async def _run_app(app: Union[Application, Awaitable[Application]], *,
                    sock: Optional[socket.socket]=None,
                    shutdown_timeout: float=60.0,
                    ssl_context: Optional[SSLContext]=None,
-                   print: Callable[..., None]=print,
+                   print: Optional[Callable[..., None]]=print,
                    backlog: int=128,
                    access_log_class: Type[AbstractAccessLogger]=AccessLogger,
                    access_log_format: str=AccessLogger.LOG_FORMAT,
@@ -379,7 +379,7 @@ def run_app(app: Union[Application, Awaitable[Application]], *,
             sock: Optional[socket.socket]=None,
             shutdown_timeout: float=60.0,
             ssl_context: Optional[SSLContext]=None,
-            print: Callable[..., None]=print,
+            print: Optional[Callable[..., None]]=print,
             backlog: int=128,
             access_log_class: Type[AbstractAccessLogger]=AccessLogger,
             access_log_format: str=AccessLogger.LOG_FORMAT,