Skip to content

Commit

Permalink
🚑 Use pip<19 in CI to mitigate a build failure
Browse files Browse the repository at this point in the history
Prior to this change, CIs were failing during build step as well
as any other attempts to install aiohttp from sdist (tarball).

This change creates a temporary workaround for #3581 and should be
reverted once the proper solution is found and implemented.
  • Loading branch information
webknjaz committed Jan 28, 2019
1 parent c145bd8 commit 9e23cf8
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ install:
# Ensure the Git Submoduldes have been pulled down too
- git submodule update --init --recursive

- "tools/build.cmd %PYTHON%\\python.exe -m pip install -U pip wheel setuptools"
- "tools/build.cmd %PYTHON%\\python.exe -m pip install -U 'pip<19' wheel setuptools"
- "tools/build.cmd %PYTHON%\\python.exe -m pip install -r requirements/cython.txt"
- "tools/build.cmd %PYTHON%\\python.exe -m pip install -r requirements/ci.txt"

Expand Down
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ python:
- &pypy3 pypy3.5

install:
- &upgrade_python_toolset pip install --upgrade pip wheel setuptools
- &upgrade_python_toolset pip install --upgrade 'pip<19' wheel setuptools
- pip install -r requirements/cython.txt
- pip install -r requirements/ci.txt

Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ doc-spelling:
@make -C docs spelling SPHINXOPTS="-W -E"

install:
@pip install -U pip
@pip install -U 'pip<19'
@pip install -Ur requirements/dev.txt

.PHONY: all build flake test vtest cov clean doc

0 comments on commit 9e23cf8

Please sign in to comment.