Fix aiohttp.ClientTimeout type annotations to accept None for fields (#…

…3511) * Fix aiohttp.ClientTimeout type annotations to accept Nonefor fields * Add changelog
aio-libs · Jan 9, 2019 · 7706b5a · 7706b5a
1 parent c562ffe
commit 7706b5a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/CHANGES/3511.bugfix b/CHANGES/3511.bugfix
@@ -0,0 +1 @@
+Fix ``aiohttp.ClientTimeout`` type annotations to accept ``None`` for fields
diff --git a/aiohttp/client.py b/aiohttp/client.py
@@ -129,10 +129,10 @@
 
 @attr.s(frozen=True, slots=True)
 class ClientTimeout:
-    total = attr.ib(type=float, default=None)
-    connect = attr.ib(type=float, default=None)
-    sock_read = attr.ib(type=float, default=None)
-    sock_connect = attr.ib(type=float, default=None)
+    total = attr.ib(type=Optional[float], default=None)
+    connect = attr.ib(type=Optional[float], default=None)
+    sock_read = attr.ib(type=Optional[float], default=None)
+    sock_connect = attr.ib(type=Optional[float], default=None)
 
     # pool_queue_timeout = attr.ib(type=float, default=None)
     # dns_resolution_timeout = attr.ib(type=float, default=None)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix ``aiohttp.ClientTimeout`` type annotations to accept ``None`` for fields