Properly close sessions in _SessionRequestContextManager (#2441)

* Properly close sessions in _SessionRequestContextManager * Add news fragment
aio-libs · Oct 30, 2017 · 10e0d97 · 10e0d97
1 parent 4cc392f
commit 10e0d97
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/CHANGES/2441.bugfix b/CHANGES/2441.bugfix
@@ -0,0 +1 @@
+_SessionRequestContextManager closes the session properly now.
diff --git a/aiohttp/client.py b/aiohttp/client.py
@@ -724,16 +724,16 @@ def __init__(self, coro, session):
     def __iter__(self):
         try:
             return (yield from self._coro)
-        except:
-            self._session.close()
+        except BaseException:
+            yield from self._session.close()
             raise
 
     if PY_35:
         def __await__(self):
             try:
                 return (yield from self._coro)
-            except:
-                self._session.close()
+            except BaseException:
+                yield from self._session.close()
                 raise
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		_SessionRequestContextManager closes the session properly now.