Fix #3480: Remove deprecation warning (#3481)

aio-libs · Jan 4, 2019 · 0715ae7 · 0715ae7
1 parent 4c7bc9f
commit 0715ae7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/CHANGES/3480.bugfix b/CHANGES/3480.bugfix
@@ -0,0 +1 @@
+Replace ``collections.MutableMapping`` with ``collections.abc.MutableMapping`` to avoid a deprecation warning.
diff --git a/aiohttp/web_response.py b/aiohttp/web_response.py
@@ -1,5 +1,5 @@
 import asyncio  # noqa
-import collections  # noqa
+import collections.abc  # noqa
 import datetime
 import enum
 import json
@@ -39,7 +39,7 @@
     from .web_request import BaseRequest  # noqa
     BaseClass = MutableMapping[str, Any]
 else:
-    BaseClass = collections.MutableMapping
+    BaseClass = collections.abc.MutableMapping
 
 
 class ContentCoding(enum.Enum):

diff --git a/tests/test_web_response.py b/tests/test_web_response.py
@@ -1,4 +1,4 @@
-import collections
+import collections.abc
 import datetime
 import gzip
 import json
@@ -94,7 +94,7 @@ def test_stream_response_eq() -> None:
 
 def test_stream_response_is_mutable_mapping() -> None:
     resp = StreamResponse()
-    assert isinstance(resp, collections.MutableMapping)
+    assert isinstance(resp, collections.abc.MutableMapping)
     resp['key'] = 'value'
     assert 'value' == resp['key']
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Replace ``collections.MutableMapping`` with ``collections.abc.MutableMapping`` to avoid a deprecation warning.