A workaround for issue #565 #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows the tests to run multiple times without leaving processes behind or leaving port 8000 open.
This reverts commit 11eab74.
Co-authored-by: Sam Bull <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #566 +/- ##
==========================================
+ Coverage 86.33% 91.77% +5.43%
==========================================
Files 12 12
Lines 754 754
Branches 124 124
==========================================
+ Hits 651 692 +41
+ Misses 81 39 -42
- Partials 22 23 +1
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
haukex
added a commit
to haukex/aiohttp-devtools
that referenced
this pull request
Jun 2, 2023
Dreamsorcerer
added a commit
that referenced
this pull request
Jun 28, 2023
* Work around signals on Windows (fixes #548) As discussed in the issue above, this works around signals not working properly on Windows by setting up an endpoint that shuts down the server. * Update requirements.txt A few required packages were not named, and updated pytest. * Fix _stop_dev_server when _session isn't set * Get tests working * Added CHANGES file * Fixups for linter * Skip a test on Python 3.7 * Delete 548.bugfix * A workaround for issue #565 This change allows the tests to run multiple times without leaving processes behind or leaving port 8000 open. * Revert "Update requirements.txt" This reverts commit 778ddbe. This is now taken care of by my pull request #564. * Apply a suggestion from code review Co-authored-by: Sam Bull <[email protected]> * Apply a suggestion from code review Co-authored-by: Sam Bull <[email protected]> * The issue #565 workaround needs to be adjusted Because in this branch we've changed _stop_dev_server to be async * Added a test for handlers Tests whether on_startup, cleanup_ctx, and on_shutdown handlers are called. * Revert "A workaround for issue #565" This reverts commit 11eab74. * Fix #565 Co-authored-by: Sam Bull <[email protected]> * Remove an unused function * Turn off fail-fast on tests * Hopefully make linter happy * test_runserver_cleanup.py needs the #566 patch * Copy over a filterwarnings to try and fix failures * Fix requirements-dev.txt on Python 3.7 * Began work on test_server_cleanup_byurl (unfinished) * Revert "Began work on test_server_cleanup_byurl (unfinished)" This reverts commit 54eced8. * Working shutdown/cleanup code The manual test in cleanup_app.py passed on Windows 10, Python 3.7 through 3.11. * The two tests marked non_windows_test now work * Revert "Turn off fail-fast on tests" This reverts commit 15317f3. Not needed anymore now that all tests are passing * Revert "Fix requirements-dev.txt on Python 3.7" This reverts commit dcbe025. PR #569 was rejected and I mainly needed it for testing. * Make linter happy again * Update aiohttp_devtools/runserver/watch.py * Revert af852e0, thereby restoring 54eced8 This reverts commit af852e0, which reverted commit 54eced8 "Began work on test_server_cleanup_byurl (unfinished)" because it turns out we can use that code as a basis to test on Linux. * Added --shutdown-by-url to CLI * Replaced test_server_cleanup with _byurl version * Update watch.py * Update cli.py * Update config.py * Update serve.py * Update cleanup_app.py * Update test_runserver_cleanup.py * Update test_runserver_cleanup.py * Update watch.py * Update cleanup_app.py --------- Co-authored-by: Sam Bull <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I was able to come up with to fix #565, that is, it allows the tests to be run multiple times without them leaving processes behind or leaving port 8000 open. However, I'm having trouble keeping track of how the devtools start up and shut down servers, so I'm uncertain if this is a good solution; it may just be a workaround or hack...