Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client + endpoint updates #48

Merged
merged 8 commits into from
Apr 8, 2016
Merged

client + endpoint updates #48

merged 8 commits into from
Apr 8, 2016

Conversation

thehesiod
Copy link
Collaborator

  • adds "async with" support to client
  • enables aiohttp retry-able exceptions
  • removes ClientResponseContentProxy del since ClientResponse will close + warn user
  • fixes "async with" support for ClientResponseContentProxy (missing yield from)
  • fixes endpoint's _get_response to handler aiohttp exceptions and put logging back
  • fixes endpoint's request timeout to be connect + read timeout

this continues #44

@thehesiod thehesiod changed the title endpoint updates client + endpoint updates Apr 8, 2016
jettify
jettify reviewed Apr 8, 2016
View reviewed changes
aiobotocore/endpoint.py
def __init__(self, *args, **kwargs):
self._impl = ClientResponse(*args, **kwargs)
self._body = None
self._response = ClientResponse(*args, **kwargs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This even better! Later we can figure out what exact methods and properties are used and only proxy those.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me know if you want me to put it back to _impl

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_resonpce is more clear I think

@jettify
Copy link
Member

jettify commented Apr 8, 2016

Tests are green, changed looks good!

@jettify
Copy link
Member

jettify commented Apr 8, 2016

Probably I will add some code to the tests today, so we can do async/awiat tests in same codebase

@jettify jettify merged commit 126cea5 into aio-libs:master Apr 8, 2016
@thehesiod
Copy link
Collaborator Author

cool! sorry about my unittest laziness :)

@thehesiod thehesiod deleted the timeout-fix branch April 8, 2016 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thehesiod @jettify