This repository has been archived by the owner on Feb 21, 2023. It is now read-only.
Add test markers to allow more granularity selecting tests #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-novikov
force-pushed
the
m-novikov-pytest-markers
branch
from
7894682 to
aeed245
Compare
To speed up testing add markers for selecting/deselecting following cases: * hiredis_parser * python_parser * connection pool * single connection
m-novikov
force-pushed
the
m-novikov-pytest-markers
branch
from
aeed245 to
f147e1a
Compare
Codecov Report
@@ Coverage Diff @@
## master #1219 +/- ##
==========================================
+ Coverage 90.68% 90.71% +0.02%
==========================================
Files 21 21
Lines 6872 6872
Branches 793 793
==========================================
+ Hits 6232 6234 +2
+ Misses 468 467 -1
+ Partials 172 171 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Andrew-Chen-Wang
approved these changes
Dec 24, 2021
seandstewart
approved these changes
Feb 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To speed up testing add markers for selecting/deselecting following cases:
What do these changes do?
Following up on #1213 as the current test suite could take longer to run, it makes sense to have more granularity when selecting tests.
It is probably most convenient to use for deselecting tests. For example:
pytest -k "not python_parser and not connection_pool" -vAre there changes in behavior for the user?
No changes to behavior
Related issue number
#1213
Checklist
CONTRIBUTORS.txt<Name> <Surname>.CHANGES/folder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.