Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Resolve issues with PR checks #3270

Merged
merged 3 commits into from
Dec 18, 2024
Merged

[fix] Resolve issues with PR checks #3270

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac641de
[fix] Resolve issues with PR checks
mihran113 Dec 16, 2024
04b8961
Merge branch 'main' into fix/pr-checks
mihran113 Dec 18, 2024
08e8a9c
Fix formatting
mihran113 Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
- name: setup python
uses: actions/setup-python@v2
with:
python-version: '3.7'
python-version: '3.8'
architecture: x64

- name: install deps
Expand Down
5 changes: 3 additions & 2 deletions aim/sdk/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,10 +418,11 @@ def track(

# artifacts logging API
@property
def artifacts_uri(self) -> str:
def artifacts_uri(self) -> Optional[str]:
if self._run_artifacts_uri is None:
base_uri = self.meta_run_tree.get('artifacts_uri', None)
if base_uri is None: return None
if base_uri is None:
return None
self._run_artifacts_uri = os.path.join(base_uri, self.hash)
return self._run_artifacts_uri

Expand Down
6 changes: 5 additions & 1 deletion aim/storage/artifacts/s3_storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,15 +76,19 @@ def _get_s3_client(self):
def S3ArtifactStorage_factory(**boto3_client_kwargs: dict):
class S3ArtifactStorageCustom(S3ArtifactStorage):
def _get_s3_client(self):
import boto3, botocore
import boto3
import botocore

if 'config' in boto3_client_kwargs and isinstance(boto3_client_kwargs['config'], dict):
config_kwargs = boto3_client_kwargs.pop('config')
boto3_client_kwargs['config'] = botocore.config.Config(**config_kwargs)
client = boto3.client('s3', **boto3_client_kwargs)
return client

return S3ArtifactStorageCustom


def S3ArtifactStorage_clientconfig(**boto3_client_kwargs: dict):
from aim.storage.artifacts import registry

registry.registry['s3'] = S3ArtifactStorage_factory(**boto3_client_kwargs)
Loading